Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Go-Datepicker: Set timezone based on user's settings #282

Merged
merged 2 commits into from
Oct 23, 2019
Merged

[Bugfix] Go-Datepicker: Set timezone based on user's settings #282

merged 2 commits into from
Oct 23, 2019

Conversation

patrick-lewandowski
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #277

Date adapter incorrectly formats dates for users in different timezones.

What is the new behavior?

Date adapter correctly formats dates based on users timezone.

Does this PR introduce a breaking change?

  • Yes
  • No

(not sure honestly)

Other information

@grahamhency grahamhency added this to the v1.3.0 milestone Oct 23, 2019
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@StevenUlmer StevenUlmer merged commit 1b8bd2a into mobi:v1.3.0 Oct 23, 2019
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
@patrick-lewandowski patrick-lewandowski deleted the datepicker-timezone branch November 14, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants